Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bls): validate proof of possession #815

Merged
merged 23 commits into from
Feb 20, 2024
Merged

feat(bls): validate proof of possession #815

merged 23 commits into from
Feb 20, 2024

Conversation

dhrubabasu
Copy link
Contributor

Validates the BLS public key + signature when creating a new ProofOfPossession

@dhrubabasu dhrubabasu self-assigned this Feb 16, 2024
src/crypto/bls.ts Outdated Show resolved Hide resolved
@dhrubabasu dhrubabasu marked this pull request as draft February 17, 2024 00:46
@dhrubabasu dhrubabasu changed the base branch from master to crypto-pkg February 18, 2024 00:33
@dhrubabasu dhrubabasu marked this pull request as ready for review February 18, 2024 00:39
@dhrubabasu dhrubabasu changed the base branch from crypto-pkg to master February 18, 2024 00:49
@dhrubabasu dhrubabasu changed the base branch from master to crypto-pkg February 18, 2024 00:49
bferenc
bferenc previously approved these changes Feb 19, 2024
gergelylovas
gergelylovas previously approved these changes Feb 20, 2024
Base automatically changed from crypto-pkg to master February 20, 2024 16:59
@dhrubabasu dhrubabasu dismissed stale reviews from gergelylovas and bferenc February 20, 2024 16:59

The base branch was changed.

@dhrubabasu dhrubabasu merged commit 273b8ca into master Feb 20, 2024
3 checks passed
@dhrubabasu dhrubabasu deleted the bls branch February 20, 2024 17:06
github-actions bot pushed a commit that referenced this pull request Feb 20, 2024
# [3.18.0](v3.17.0...v3.18.0) (2024-02-20)

### Features

* **bls:** add signing functions ([#817](#817)) ([8cb2fbe](8cb2fbe))
* **bls:** validate proof of possession ([#815](#815)) ([273b8ca](273b8ca))
* release v4 [skip ci] ([#811](#811)) ([39d652e](39d652e))

### BREAKING CHANGES

* switch to v4 API
gergelylovas added a commit that referenced this pull request Feb 20, 2024
bls: add signing functions (#817) (8cb2fbe)
bls: validate proof of possession (#815) (273b8ca)
release v4 [skip ci] (#811) (39d652e)
github-actions bot pushed a commit to BitGo/avalanchejs that referenced this pull request Mar 26, 2024
# 1.0.0 (2024-03-26)

### Bug Fixes

* add base tx example ([be22d56](be22d56))
* Add tests ([6776d71](6776d71))
* AVM `importAVA` // `exportAVA` documentation ([beebaf1](beebaf1))
* BN toString in params ([572c055](572c055))
* Implement `importKey` , `exportKey` for platformAPI ([02485d4](02485d4))
* imports ([207f6eb](207f6eb))
* only use fetch if available ([df9570b](df9570b))
* reference ES module on main ([ava-labs#832](https://github.com/BitGo/avalanchejs/issues/832)) ([d872f79](d872f79))
* Remove `subnet` from params in `addNonDefaultSubnetValidator` ([7c7a9ce](7c7a9ce))
* rename to @bitgo/avalanchejs ([3e354b6](3e354b6))
* Revert linting ([73ff260](73ff260))
* **tests:** broke jest, update ts-jest ([c798b1c](c798b1c))
* Typo `usermame` => `username` ([cd1ca70](cd1ca70))
* update `package.json` to reference the fork repo ([411de7e](411de7e))
* upgrade store2 from 2.12.0 to 2.13.1 ([71a6d0b](71a6d0b))
* upgrade ws from 8.3.0 to 8.4.0 ([7f60d41](7f60d41))
* use noble/curves instead of noble/secp256k1 ([09fc8ab](09fc8ab))
* use pchain blockchain id ([4cf3ea1](4cf3ea1))
* use ripemd160 instead of rmd160 as algorithm descriptor ([08bc6b0](08bc6b0))
* version number ([ava-labs#821](https://github.com/BitGo/avalanchejs/issues/821)) ([e1d6726](e1d6726))

### Features

* Add call to `admin.getNetworkName` ([414020b](414020b))
* Add call to `admin.getNodeVersion` ([2294cf4](2294cf4))
* add HealthAPI ([4ef9c05](4ef9c05))
* add HealthAPI ([f808303](f808303))
* **bls:** add signing functions ([ava-labs#817](https://github.com/BitGo/avalanchejs/issues/817)) ([8cb2fbe](8cb2fbe))
* **bls:** validate proof of possession ([ava-labs#815](https://github.com/BitGo/avalanchejs/issues/815)) ([273b8ca](273b8ca))
* **lint:** run lint staged on commit, instead of full lint ([c743c9f](c743c9f))
* release v4 [skip ci] ([ava-labs#811](https://github.com/BitGo/avalanchejs/issues/811)) ([39d652e](39d652e))
* **release:** auto release on release branch ([14fce27](14fce27))
* **release:** now adding release for master and release branch ([9c0cd92](9c0cd92))
* **release:** release master alpha build ([51f7e92](51f7e92))
* Rename test ([bf83f6a](bf83f6a))
* Revert mistake ([cf3c9de](cf3c9de))
* support node 18 ([61384cc](61384cc))
* use fetch for network requests ([74332a3](74332a3))

### BREAKING CHANGES

* switch to v4 API
github-actions bot pushed a commit to BitGo/avalanchejs that referenced this pull request Mar 26, 2024
# 1.0.0 (2024-03-26)

### Bug Fixes

* add base tx example ([be22d56](be22d56))
* add publishConfig to package.json ([f7a188e](f7a188e))
* Add tests ([6776d71](6776d71))
* AVM `importAVA` // `exportAVA` documentation ([beebaf1](beebaf1))
* BN toString in params ([572c055](572c055))
* Implement `importKey` , `exportKey` for platformAPI ([02485d4](02485d4))
* imports ([207f6eb](207f6eb))
* only use fetch if available ([df9570b](df9570b))
* reference ES module on main ([ava-labs#832](https://github.com/BitGo/avalanchejs/issues/832)) ([d872f79](d872f79))
* Remove `subnet` from params in `addNonDefaultSubnetValidator` ([7c7a9ce](7c7a9ce))
* rename to @bitgo/avalanchejs ([3e354b6](3e354b6))
* Revert linting ([73ff260](73ff260))
* **tests:** broke jest, update ts-jest ([c798b1c](c798b1c))
* Typo `usermame` => `username` ([cd1ca70](cd1ca70))
* update `package.json` to reference the fork repo ([411de7e](411de7e))
* upgrade store2 from 2.12.0 to 2.13.1 ([71a6d0b](71a6d0b))
* upgrade ws from 8.3.0 to 8.4.0 ([7f60d41](7f60d41))
* use noble/curves instead of noble/secp256k1 ([09fc8ab](09fc8ab))
* use pchain blockchain id ([4cf3ea1](4cf3ea1))
* use ripemd160 instead of rmd160 as algorithm descriptor ([08bc6b0](08bc6b0))
* version number ([ava-labs#821](https://github.com/BitGo/avalanchejs/issues/821)) ([e1d6726](e1d6726))

### Features

* Add call to `admin.getNetworkName` ([414020b](414020b))
* Add call to `admin.getNodeVersion` ([2294cf4](2294cf4))
* add HealthAPI ([4ef9c05](4ef9c05))
* add HealthAPI ([f808303](f808303))
* **bls:** add signing functions ([ava-labs#817](https://github.com/BitGo/avalanchejs/issues/817)) ([8cb2fbe](8cb2fbe))
* **bls:** validate proof of possession ([ava-labs#815](https://github.com/BitGo/avalanchejs/issues/815)) ([273b8ca](273b8ca))
* **lint:** run lint staged on commit, instead of full lint ([c743c9f](c743c9f))
* release v4 [skip ci] ([ava-labs#811](https://github.com/BitGo/avalanchejs/issues/811)) ([39d652e](39d652e))
* **release:** auto release on release branch ([14fce27](14fce27))
* **release:** now adding release for master and release branch ([9c0cd92](9c0cd92))
* **release:** release master alpha build ([51f7e92](51f7e92))
* Rename test ([bf83f6a](bf83f6a))
* Revert mistake ([cf3c9de](cf3c9de))
* support node 18 ([61384cc](61384cc))
* use fetch for network requests ([74332a3](74332a3))

### BREAKING CHANGES

* switch to v4 API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants